Skip to content

Rename Match and MatchResult to Output and Regex.Match. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Mar 21, 2022

  • Rename the Match associatedtype in RegexComponent to Output.
  • Rename MatchResult to Regex.Match.

The new names have been pitched as part of the regex type and the regex builder DSL.

@rxwei rxwei requested a review from milseman March 21, 2022 03:08
@rxwei
Copy link
Contributor Author

rxwei commented Mar 21, 2022

@swift-ci please test

- Rename the `Match` associatedtype in `RegexComponent` to `Output`.
- Rename `MatchResult` to `Regex.Match`.

The new names have been pitched as part of the [regex type](https://forums.swift.org/t/pitch-regex-type-and-overview/56029) and the [regex builder DSL](https://forums.swift.org/t/pitch-regex-builder-dsl/56007).
@rxwei rxwei force-pushed the rename-regex-match branch from 29f9954 to ed92d3b Compare March 21, 2022 06:04
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxwei
Copy link
Contributor Author

rxwei commented Mar 21, 2022

@swift-ci please test

@rxwei rxwei merged commit c97cd0d into swiftlang:main Mar 21, 2022
@rxwei rxwei deleted the rename-regex-match branch March 21, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants